Bug 233728

Summary: AX Isolated Tree: Document links should be stored in web areas, not the root
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=98382
Attachments:
Description Flags
Patch
none
Patch none

Tyler Wilcock
Reported 2021-12-01 15:00:32 PST
In WebAccessibilityObjectWrapperMac.mm, we expose the document links attribute (AXLinkUIElements) on web areas. However, in AXIsolatedObject::initializeAttributeData we currently only store AXPropertyName::DocumentLinks for the root element, which is not a web area. This causes accessibility/visible-elements.html to fail. https://github.com/WebKit/WebKit/blob/109c8234854a0fa28955d81994bb98daa1fa14fe/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm#L2235#L2237
Attachments
Patch (7.82 KB, patch)
2021-12-01 15:28 PST, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (7.79 KB, patch)
2021-12-01 15:30 PST, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-12-01 15:00:52 PST
<rdar://problem/85941419>
Tyler Wilcock
Comment 2 2021-12-01 15:28:03 PST
Created attachment 445625 [details] Patch
Tyler Wilcock
Comment 3 2021-12-01 15:30:11 PST
Created attachment 445626 [details] Patch
EWS
Comment 4 2021-12-02 07:25:59 PST
Committed r286426 (244772@main): <https://commits.webkit.org/244772@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445626 [details].
Note You need to log in before you can comment on or make changes to this bug.