Bug 234694

Summary: Make -webkit-text-combine an inherited property
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: CSSAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 150821    
Attachments:
Description Flags
Patch
simon.fraser: review+
Patch
none
[fast-cq] Patch none

Tim Nguyen (:ntim)
Reported 2021-12-26 11:25:06 PST
-webkit-text-combine is said to be inherited in CSSProperties.json, but it is not actually the case. It should be inherited per-spec (for text-combine-upright). https://drafts.csswg.org/css-writing-modes/#text-combine-upright
Attachments
Patch (11.81 KB, patch)
2021-12-26 11:28 PST, Tim Nguyen (:ntim) 		simon.fraser: review+
DetailsFormatted DiffDiff
Patch (3.44 KB, patch)
2021-12-26 11:39 PST, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
[fast-cq] Patch (11.68 KB, patch)
2021-12-26 15:59 PST, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Nguyen (:ntim)
Comment 1 2021-12-26 11:26:21 PST
Some WPT actually exist for this: css/css-writing-modes/text-combine-upright-inherit-all-001.html css/css-writing-modes/text-combine-upright-inherit-all-002.html
Tim Nguyen (:ntim)
Comment 2 2021-12-26 11:28:33 PST
Created attachment 447983 [details] Patch
Tim Nguyen (:ntim)
Comment 3 2021-12-26 11:39:45 PST
Created attachment 447985 [details] Patch
Tim Nguyen (:ntim)
Comment 4 2021-12-26 11:40:12 PST
Comment on attachment 447985 [details] Patch Wrong bug
Simon Fraser (smfr)
Comment 5 2021-12-26 13:21:28 PST
Comment on attachment 447983 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=447983&action=review > LayoutTests/fast/text/text-combine-inherited.html:6 > +<link rel="author" title="Tim Nguyen" href="https://github.com/nt1m"> > +<link rel="match" href="text-combine-inherited-expected.html"> We don't normally add these to non-WPT tests.
Tim Nguyen (:ntim)
Comment 6 2021-12-26 15:59:59 PST
Created attachment 447991 [details] [fast-cq] Patch
EWS
Comment 7 2021-12-26 16:04:50 PST
Committed r287451 (245586@main): <https://commits.webkit.org/245586@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447991 [details].
Radar WebKit Bug Importer
Comment 8 2021-12-26 16:05:20 PST
<rdar://problem/86923772>
Note You need to log in before you can comment on or make changes to this bug.