Bug 235083

Summary: [cocoa] Allow TestWebKitAPI::HTTPServer to run non-loopback addresses for API tests
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: Tools / TestsAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED WONTFIX    
Severity: Normal CC: ap
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=219257
Attachments:
Description Flags
Patch ews-feeder: commit-queue-

Frédéric Wang (:fredw)
Reported 2022-01-11 14:27:19 PST
Currently TestWebKitAPI::HTTPServer only allows to use 127.0.0.1 or localhost as host names.
Attachments
Patch (13.92 KB, patch)
2022-01-11 14:29 PST, Frédéric Wang (:fredw) 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2022-01-11 14:29:20 PST
Created attachment 448879 [details] Patch
Alexey Proskuryakov
Comment 2 2022-01-11 18:47:01 PST
I don’t think that this should be possible. Exposing test code over network (even local) is a security problem, and we are explicitly preventing that in tests.
Frédéric Wang (:fredw)
Comment 3 2022-01-12 00:19:32 PST
Using this hardcoded 192.168.0.10 IP address seems to work on my local machine, but the requests time out on the api bots. (In reply to Alexey Proskuryakov from comment #2) > I don’t think that this should be possible. Exposing test code over network > (even local) is a security problem, and we are explicitly preventing that in > tests. Makes sense. Let's close as WONTFIX then.
Note You need to log in before you can comment on or make changes to this bug.