Bug 237701

Summary: Unify reference box / CTM computation in RenderLayer
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: Layout and RenderingAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, dino, esprehn+autocc, ews-watchlist, fmalita, fred.wang, glenn, gyuyoung.kim, kondapallykalyan, pdr, rbuis, sabouhallawa, schenney, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 237553, 237554    
Bug Blocks: 90738, 211787, 237711    
Attachments:
Description Flags
Patch, v1
none
Patch, v2
none
Patch, v3
none
Patch, v4
none
Patch, v5
none
Patch, v6
none
Patch, v7
none
Patch, v8
none
Patch, v9
none
Patch, v10 rbuis: review+

Nikolas Zimmermann
Reported 2022-03-10 01:32:05 PST
Currently RenderLayer::updateTransform() and RenderLayer::currentTransform() contain code to compute the CTM, apply pixel snapping, etc. Unify them into a single updateTransformFromStyle() helper method, that can be used later by LBSE to e.g. disable pixel snapping for the SVG subtree in one place, instead of sprinkling LBSE code over multiple places.
Attachments
Patch, v1 (18.92 KB, patch)
2022-03-10 01:34 PST, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch, v2 (18.92 KB, patch)
2022-03-10 05:56 PST, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch, v3 (18.88 KB, patch)
2022-03-10 06:17 PST, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch, v4 (21.33 KB, patch)
2022-03-10 15:37 PST, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch, v5 (20.04 KB, patch)
2022-03-13 16:46 PDT, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch, v6 (20.03 KB, patch)
2022-03-16 03:25 PDT, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch, v7 (19.46 KB, patch)
2022-03-21 02:50 PDT, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch, v8 (19.46 KB, patch)
2022-04-04 13:34 PDT, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch, v9 (19.95 KB, patch)
2022-04-05 14:58 PDT, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch, v10 (19.98 KB, patch)
2022-04-07 03:24 PDT, Nikolas Zimmermann 		rbuis: review+
DetailsFormatted DiffDiff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2022-03-10 01:34:23 PST
Created attachment 454324 [details] Patch, v1
Nikolas Zimmermann
Comment 2 2022-03-10 05:56:51 PST
Created attachment 454349 [details] Patch, v2
Nikolas Zimmermann
Comment 3 2022-03-10 06:17:41 PST
Created attachment 454355 [details] Patch, v3
Nikolas Zimmermann
Comment 4 2022-03-10 15:37:42 PST
Created attachment 454410 [details] Patch, v4
Nikolas Zimmermann
Comment 5 2022-03-13 16:46:45 PDT
Created attachment 454561 [details] Patch, v5
Nikolas Zimmermann
Comment 6 2022-03-16 03:25:30 PDT
Created attachment 454816 [details] Patch, v6
Radar WebKit Bug Importer
Comment 7 2022-03-16 05:39:59 PDT
<rdar://problem/90364879>
Nikolas Zimmermann
Comment 8 2022-03-21 02:50:39 PDT
Created attachment 455225 [details] Patch, v7
Nikolas Zimmermann
Comment 9 2022-04-04 13:34:46 PDT
Created attachment 456617 [details] Patch, v8
Nikolas Zimmermann
Comment 10 2022-04-05 14:58:45 PDT
Created attachment 456752 [details] Patch, v9
Nikolas Zimmermann
Comment 11 2022-04-07 03:24:05 PDT
Created attachment 456901 [details] Patch, v10
Rob Buis
Comment 12 2022-04-07 06:18:47 PDT
Comment on attachment 456901 [details] Patch, v10 View in context: https://bugs.webkit.org/attachment.cgi?id=456901&action=review > Source/WebCore/rendering/svg/RenderSVGTransformableContainer.h:50 > + Empty line maybe not needed.
Nikolas Zimmermann
Comment 13 2022-04-07 15:56:42 PDT
Committed r292575 (?): <https://commits.webkit.org/r292575>
Note You need to log in before you can comment on or make changes to this bug.