Bug 239806

Summary: [RISCV64] Implement MacroAssemblerRISCV64 branchAtomicWeakCAS{8,16,32,64} methods
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 237775    
Attachments:
Description Flags
Patch
none
Patch for landing none

Zan Dobersek
Reported 2022-04-27 00:55:00 PDT
[RISCV64] Implement MacroAssemblerRISCV64 branchAtomicWeakCAS{8,16,32,64} methods
Attachments
Patch (9.69 KB, patch)
2022-04-27 00:56 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (9.57 KB, patch)
2022-04-28 03:03 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2022-04-27 00:56:14 PDT
Created attachment 458430 [details] Patch
Yusuke Suzuki
Comment 2 2022-04-28 00:48:45 PDT
Comment on attachment 458430 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=458430&action=review r=me with nit.D > Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h:3366 > + { > + Jump success = makeBranch(Equal, temp.data(), RISCV64Registers::zero); > + failure.link(this); > + return JumpList(success); > + } style is, case Success: { ... } > Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h:3405 > + { > + Jump success = makeBranch(Equal, temp.data(), RISCV64Registers::zero); > + failure.link(this); > + return JumpList(success); > + } Ditto. > Source/JavaScriptCore/assembler/MacroAssemblerRISCV64.h:3432 > + { > + Jump success = makeBranch(Equal, temp.data(), RISCV64Registers::zero); > + failure.link(this); > + return JumpList(success); > + } Ditto.
Zan Dobersek
Comment 3 2022-04-28 03:03:03 PDT
Created attachment 458507 [details] Patch for landing With style changes.
Zan Dobersek
Comment 4 2022-04-28 03:06:53 PDT
Comment on attachment 458507 [details] Patch for landing Clearing flags on attachment: 458507 Committed r293571 (250085@trunk): <https://commits.webkit.org/250085@trunk>
Zan Dobersek
Comment 5 2022-04-28 03:06:59 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2022-04-28 03:07:19 PDT
<rdar://problem/92450245>
Note You need to log in before you can comment on or make changes to this bug.