Bug 241241

Summary:	Enable CSSTextAlignLast setting by default
Product:	WebKit	Reporter:	Tim Nguyen (:ntim) <ntim>
Component:	CSS	Assignee:	Tim Nguyen (:ntim) <ntim>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	rcaliman, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:	241301
Bug Blocks:	146772

Tim Nguyen (:ntim)

Reported 2022-06-02 14:53:18 PDT

Looking at WPT results after bug 241050, we're pretty much on par with Chrome & Firefox. So it might be worth enabling if it's ready.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2022-06-02 15:12:12 PDT

<rdar://problem/94313487>

Kiet Ho

Comment 2 2022-06-03 15:39:37 PDT

These text-align-last tests in WPT don't have a reference, thus they don't get tested during layout tests: LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-{001-009}.html LayoutTests/imported/w3c/web-platform-tests/css/css-text/text-align/text-align-last-{012-014}.html It would be a good idea to write reference results for them and make sure WebKit passes all of them before enabling text-align-last by default.

Tim Nguyen (:ntim)

Comment 3 2022-06-06 02:01:37 PDT

I'm confident we should have enough coverage after bug 241305.

Tim Nguyen (:ntim)

Comment 4 2022-06-14 10:08:45 PDT

Pull request: https://github.com/WebKit/WebKit/pull/1506

EWS

Comment 5 2022-06-14 14:01:19 PDT

Committed r295535 (251540@main): <https://commits.webkit.org/251540@main> Reviewed commits have been landed. Closing PR #1506 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.