Bug 24317

Summary: hitTest() on a multi line input only works through happenstance.
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: FormsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: adele, mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 24312    
Attachments:
Description Flags
Patch hyatt: review+

Simon Fraser (smfr)
Reported 2009-03-02 22:43:13 PST
Another, just like bug 24313: Hit testing on a RenderTextControlMultiLine seems to work only because of a side-effect of HitTestResult behavior. What I see happening is this: RenderLayer::hitTest calls hitTest() on the renderer, which goes into RenderTextControlMultiLine::nodeAtPoint(). This ends up setting some text node inside the textarea as the innerNode() on the result. However, RenderTextControlMultiLine::nodeAtPoint() then returns false! So we continue to hit test all the way up to the body. The body's layer ends up being the one hit, but we use the node in the result anyway. This is hurting my karma. See bug 24312.
Attachments
Patch (1.49 KB, patch)
2009-03-02 23:05 PST, Simon Fraser (smfr) 		hyatt: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2009-03-02 23:05:00 PST
Created attachment 28213 [details] Patch
Dave Hyatt
Comment 2 2009-03-03 09:05:59 PST
Comment on attachment 28213 [details] Patch r=me
Simon Fraser (smfr)
Comment 3 2009-03-03 09:43:57 PST
http://trac.webkit.org/changeset/41385
Note You need to log in before you can comment on or make changes to this bug.