Bug 24816

Summary:

Wean KURLGoogle off the deprecated GoogleURL UTF16Char type

Product:

WebKit

Reporter:

Mark Mentovai <mark>

Component:

WebCore Misc.

Assignee:

Mark Mentovai <mark>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

abarth, andersca, brettw, dglazkov

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

37641

Attachments:

Description	Flags
Do it	eric: review-

Mark Mentovai

Reported 2009-03-25 14:32:02 PDT

UTF16Char is going away. http://code.google.com/p/google-url/source/detail?r=100

Attachments
Do it (3.41 KB, patch) 2009-03-25 14:34 PDT, Mark Mentovai	eric: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Mark Mentovai

Comment 1 2009-03-25 14:34:19 PDT

Created attachment 28947 [details] Do it Brett's really the one who should look at this, but Dimitri's a real reviewer, so you two can duke it out.

Brett Wilson (Google)

Comment 2 2009-03-25 20:31:16 PDT

looks good to me

Eric Seidel (no email)

Comment 3 2009-03-25 21:00:24 PDT

Comment on attachment 28947 [details] Do it Me too. Although why char16 over UChar or unsigned short or whatever other char types we use in WebCore? I've never seen char16 used in WebCore before... Maybe I've just not paid attention.

Mark Mentovai

Comment 4 2009-03-25 21:19:02 PDT

char16 is because we need to access these templates in GoogleURL, and that's how it (now) refers to them. GoogleURL gets its char16/string16 support from its restricted version of the Chromium base. KURLGoogle is the "glue" between WebKit and GoogleURL, it shouldn't leak/expose char16 or string16 to the rest of WebKit, and it doesn't. From WebKit's perspective, it's just platform-specific stuff.

Darin Fisher (:fishd, Google)

Comment 5 2009-03-25 22:33:43 PDT

Mark: but the appearance of char16 in WebCore/platform/KURLGooglePrivate.h suggests that there is some considerable leakage. it seems unfortunate to require the presence of a base/string16.h header when building WebKit when we don't actually need string16... we just need something exactly equivalent to UChar.

Darin Fisher (:fishd, Google)

Comment 6 2009-03-25 22:36:47 PDT

Mark: instead of trying to teach GoogleURL to know about a global char16 type, I think it would be better to let it keep its own UTF16Char type, but then define it in a compatible with char16 and UChar fashion, like what is done at the bottom of this file: http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebKit/chromium/public/WebCommon.h?view=markup

Eric Seidel (no email)

Comment 7 2009-03-25 23:00:06 PDT

Comment on attachment 28947 [details] Do it Based on Darin's comments, I'll remove my review, and let you and Darin sort this one out. :)

Anders Carlsson

Comment 8 2013-09-12 22:40:56 PDT

KURLGoogle is gone.

Note You need to log in before you can comment on or make changes to this bug.