Bug 250817

Summary:	Remove templates GCGLSpan & GCGLSpanTuple from GraphicsTypesGL.h
Product:	WebKit	Reporter:	Dan Glastonbury <djg>
Component:	Layout and Rendering	Assignee:	Dan Glastonbury <djg>
Status:	RESOLVED FIXED
Severity:	Enhancement	CC:	bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified

Dan Glastonbury

Reported 2023-01-18 18:22:16 PST

To improve compile time of WebCoreArgumentCoders.h move the templates GCGLSpan & GCGLSpanTuple into their own header to be included by implementations of GraphicsContextGL. So GraphicsContextGL.h can compile with just forward declarations, move query functions getFloat, getBoolean, et al, from GraphicsContextGL.h to GraphicsContextGL.cpp

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-01-18 18:22:55 PST

<rdar://problem/104407319>

Dan Glastonbury

Comment 2 2023-01-18 22:30:52 PST

Pull request: https://github.com/WebKit/WebKit/pull/8811

EWS

Comment 3 2023-01-19 18:45:34 PST

Committed 259124@main (747785fe59b8): <https://commits.webkit.org/259124@main> Reviewed commits have been landed. Closing PR #8811 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.