Bug 250871

Summary:	Remove HTMLMediaElement.webkitPreservesPitch
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	Media	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	eric.carlson, ianhedoesit, jer.noble, karlcow, webkit-bug-importer
Priority:	P2	Keywords:	BrowserCompat, InRadar, WPTImpact
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:	214922
Bug Blocks:

Description Ahmad Saleem 2023-01-19 16:25:31 PST

Hi Team,

While going through Blink's commit, I came across another potential removal of non-standard.

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/79ddcbce61e61f4cfb09e4563c6deca94de44e6c

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/html/HTMLMediaElement.h#1053 & https://searchfox.org/wubkat/source/Source/WebCore/html/HTMLMediaElement.cpp#3892

Just wanted to get input whether it is something we can get rid of now or we still need it?

Thanks!

Comment 1 Radar WebKit Bug Importer 2023-01-19 16:31:48 PST

<rdar://problem/104451631>

Comment 2 Karl Dubost 2023-01-22 18:53:45 PST

I don't see a lot of usage on GitHub
https://github.com/search?q=webkitpreservespitch+language%3AJavaScript&type=code&l=JavaScript


BUT still I can find things like
https://github.com/scottschiller/ArmorAlley/blob/da1d98a542bf55e5595b456983776890cb27a9b5/script/soundmanager2.js#L2196-L2199

            // 01/2022: prefixes for best compatibility
            if (audioContext && sm2.usePlaybackRate) {
              a.preservesPitch = a.mozPreservesPitch = a.webkitPreservesPitch = !!s._iO.preservesPitch;
            }
            a.play();

On the side of WPT:
https://wpt.fyi/results/html/semantics/embedded-content/media-elements/preserves-pitch.html?label=master&label=experimental&aligned


MDN 
https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/preservesPitch
refers to Bug 214922


So I don't think it can be removed without first unprefixing it.

Comment 3 Karl Dubost 2023-01-22 19:00:15 PST

On the other hand the live test is passing 5 tests on the 9
http://wpt.live/html/semantics/embedded-content/media-elements/preserves-pitch.html

It requires user interaction. So Probably the failure in WPT is an infra issue. 

one of the tests is to test if it has been unprefixed.
the 3 remaining FAIL are about a difference in between the range of expected values


expected 440 +/- 23.46041055718475 but got 469.208211143695
expected 880 +/- 23.46041055718475 but got 469.208211143695
expected 220 +/- 23.46041055718475 but got 469.208211143695

Comment 4 Ian Harris 2023-09-21 21:03:49 PDT

I just ran into this. Obviously I'll still need to use the `webkit` prefix for now, but it would be nice to have `preservesPitch` be the only property to deal with for all browsers :)

Comment 5 EWS 2024-02-13 09:21:05 PST

Committed 274551@main (4ed49192487b): <https://commits.webkit.org/274551@main>

Reviewed commits have been landed. Closing PR #24237 and removing active labels.