Bug 250879

Summary:	Delete unused Windows UA string logic
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	New Bugs	Assignee:	Nobody <webkit-unassigned>
Status:	NEW ---
Severity:	Normal	CC:	ap, bfulgham, Hironori.Fujii, stephan.szabo, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Ahmad Saleem 2023-01-19 17:28:43 PST

Hi Team,

While going through Blink's commit, I came cross another clean-up commit, which can be merged into WebKit.

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/6d5bdc2b3dc4b675747a86b190fa555c5a018014

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/platform/win/SystemInfo.cpp#80 etc.

Just wanted to raise, so we can track and clean-up some old code and enjoy cleaner WebKit.

Thanks!

Comment 1 Alexey Proskuryakov 2023-01-19 18:39:30 PST

We do use this function, so probably no easy cleanup:

Source/WebKitLegacy/win/WebView.cpp:    static const NeverDestroyed<String> prefix = makeString("Mozilla/5.0 (", windowsVersionForUAString(), ") AppleWebKit/", webKitVersionString(), " (KHTML, like Gecko)");

Source/WebCore/platform/win/UserAgentWin.cpp:    return makeString("Mozilla/5.0 (", windowsVersionForUAString(), ") AppleWebKit/605.1.15 (KHTML, like Gecko)",

Comment 2 Radar WebKit Bug Importer 2023-01-26 17:29:15 PST

<rdar://problem/104721654>