Bug 250884
| Summary: | Potential Reduce calls to LayoutUnit(int) | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink's commit, I came across another potential performance optimization in reducing CPU load but it does not have test case to confirm so would like to get input.
Blink Commit - https://chromium.googlesource.com/chromium/blink/+/e3d125383e6023dccb9f052237751f1c9a8098ec
WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderBox.h#382 & https://searchfox.org/wubkat/source/Source/WebCore/platform/graphics/LayoutSize.h#67
Just wanted to raise it to get input.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
It has also initial patch to reduce CPU further:
Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=158483
Webkit Source - https://searchfox.org/wubkat/source/Source/WebCore/platform/graphics/LayoutPoint.h#40
&
https://searchfox.org/wubkat/source/Source/WebCore/platform/graphics/LayoutSize.h#52
____
Performance Test Case based on commit - https://jsfiddle.net/gz0ansv7/show
alan
yeah, we should do this regardless of any potential perf improvement (but it's a nice addition)
EWS
Committed 259177@main (42948cd0674a): <https://commits.webkit.org/259177@main>
Reviewed commits have been landed. Closing PR #8872 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/104516718>