Bug 251028
| Summary: | [Cocoa] _WKFeature instances fail bincompat isKindOfClass: check | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Elliott Williams <emw> |
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Elliott Williams
As part of the feature status rollout, we replaced the _WKExperimentalFeature / _WKInternalDebugFeature class dichotomy with a single _WKFeature base class. For bincompat, our legacy endpoints lie about their instance type and declare e.g. an NSArray<_WKExperimentalFeature *>, when the actual instance types are _WKFeature.
This matches existing behavior but causes feature instances to fail a isKindOfClass:[_WKExperimentalFeature class] check.
If we're going to lie about this, we probably need to lie more completely and override isKindOfClass.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Elliott Williams
rdar://104543339
Elliott Williams
Pull request: https://github.com/WebKit/WebKit/pull/8983
EWS
Committed 259245@main (dd7dffb5b056): <https://commits.webkit.org/259245@main>
Reviewed commits have been landed. Closing PR #8983 and removing active labels.