Bug 251100

Summary: Table cells, rows, sections or column (groups) don't support margins
Product: WebKit Reporter: Ahmad Saleem <ahmad.saleem792>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, karlcow, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
test for margin on tables element none

Ahmad Saleem
Reported 2023-01-24 11:15:05 PST
Hi Team, While going through Blink's commit, I came across this commit, which fixes FIXME, which is still present in WebKit: Blink Commit - https://src.chromium.org/viewvc/blink?revision=197770&view=revision WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderBox.cpp#3690 & https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderTableRow.cpp#151 Just wanted to raise and check if we have any plan to address FIXME as part of new layout refactoring or for time being we can merge this. Thanks!
Attachments
test for margin on tables element (977 bytes, text/html)
2023-01-24 18:58 PST, Karl Dubost 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Karl Dubost
Comment 1 2023-01-24 18:58:33 PST
Created attachment 464641 [details] test for margin on tables element Probably there should be a test about this first. And see what it does in different browsers? I uploaded a test case. No browsers react at all on the margin setting.
Radar WebKit Bug Importer
Comment 2 2023-01-31 11:16:17 PST
<rdar://problem/104876500>
EWS
Comment 3 2023-02-07 03:05:38 PST
Committed 259955@main (2c733023916d): <https://commits.webkit.org/259955@main> Reviewed commits have been landed. Closing PR #9706 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.