Bug 251175

Summary: AX: Make element-reflection-arialabelledby.html and element-reflection-ariadescribedby.html async so they can pass in ITM
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Tyler Wilcock 2023-01-25 14:46:27 PST
...
Comment 1 Radar WebKit Bug Importer 2023-01-25 14:46:39 PST
<rdar://problem/104667374>
Comment 2 Tyler Wilcock 2023-01-25 15:07:48 PST
Created attachment 464657 [details]
Patch
Comment 3 Andres Gonzalez 2023-01-26 06:21:22 PST
(In reply to Tyler Wilcock from comment #2)
> Created attachment 464657 [details]
> Patch

Looks good. Why are we using 2-space indent now? Thought the WebKit coding convention including JS is 4-space indent.
Comment 4 Tyler Wilcock 2023-01-26 14:02:05 PST
Created attachment 464673 [details]
Patch
Comment 5 Tyler Wilcock 2023-01-26 14:02:40 PST
(In reply to Andres Gonzalez from comment #3)
> (In reply to Tyler Wilcock from comment #2)
> > Created attachment 464657 [details]
> > Patch
> 
> Looks good. Why are we using 2-space indent now? Thought the WebKit coding
> convention including JS is 4-space indent.
Fixed the indentation.
Comment 6 Tyler Wilcock 2023-01-26 18:59:32 PST
Created attachment 464683 [details]
Patch
Comment 7 Tyler Wilcock 2023-01-26 20:49:02 PST
Created attachment 464684 [details]
Patch
Comment 8 EWS 2023-01-27 10:55:03 PST
Committed 259503@main (93c15846448b): <https://commits.webkit.org/259503@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 464684 [details].