Bug 251251

Summary:	Ensure FixedBitVector's WordType matches the type of BitVector::m_bitsOrPointer.
Product:	WebKit	Reporter:	Mark Lam <mark.lam>
Component:	JavaScriptCore	Assignee:	Mark Lam <mark.lam>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Mark Lam

Reported 2023-01-26 23:25:50 PST

The rest of FixedBitVector's code relies on this relationship. So, let's make it explicit. Also, fixed a bug in BitMap's API tests: testBitmapConcurrentTestAndSet() and testBitmapConcurrentTestAndClear() were exercising testAndSet() and testAndClear() respectively instead of their concurrent versions. This was originally found by Yijia Huang in https://bugs.webkit.org/show_bug.cgi?id=250847.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-01-26 23:26:13 PST

<rdar://problem/104731974>

Mark Lam

Comment 2 2023-01-26 23:29:54 PST

Pull request: https://github.com/WebKit/WebKit/pull/9211

EWS

Comment 3 2023-01-27 09:08:28 PST

Committed 259490@main (c2393f9a46af): <https://commits.webkit.org/259490@main> Reviewed commits have been landed. Closing PR #9211 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.