Bug 251285

Summary:	[WinCairo] Socks proxy resolves DNS locally instead of server
Product:	WebKit	Reporter:	Max Schmitt <max>
Component:	Platform	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED WONTFIX
Severity:	Normal	CC:	Hironori.Fujii
Priority:	P2
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Windows 10

Description Max Schmitt 2023-01-27 11:38:01 PST

WebKit Linux and macOS does when setting a socks5 proxy resolve the hostname on the socks server end. This means it sends the hostname to the socks server. The current implementation on Windows when using cURL does instead resolve it locally and just send the IP address to the socks server. This is different to how its done on Linux/macOS, Firefox, and Chromium.

Comment 1 Fujii Hironori 2023-01-29 20:12:54 PST

libcurl clearly documents the spec.
https://curl.se/libcurl/c/CURLOPT_PROXY.html

I've never used socks proxies. I don't know how important cURL's "socks5://" behavior.
But, if it's important for someone, WinCairo should keep both "socks5://" and "socks5h://" behaviors.
I think it should be kept as Playwright's logic.
https://github.com/microsoft/playwright/issues/20451

Comment 2 Max Schmitt 2023-01-30 00:58:22 PST

Yes I'm totally fine with keeping it like this, since this was easily fixable on Playwright side (to align it).

Filed it more to have an upstream reference which can be linked to for further users who run in it.

Thanks Fujii.