Bug 251296

Summary: REGRESSION(259372@main): ASSERTION FAILED: !m_disabledFieldsetElementsCount on fast/forms/fieldset/fieldset-elements.html
Product: WebKit Reporter: Bri Harris <bharris9>
Component: DOMAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, ashvayka, rniwa, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Crash Log none

Description Bri Harris 2023-01-27 14:48:03 PST 
fast/forms/fieldset/fieldset-elements.html

is a flaky crash on iPad OS, Big Sur and later Debug. 

HISTORY: 
https://results.webkit.org/?suite=layout-tests&test=fast%2Fforms%2Ffieldset%2Ffieldset-grid.html


Crash Log is attached. 

CRASH LOG TEXT: 

stderr:
ASSERTION FAILED: !m_disabledFieldsetElementsCount
dom/Document.cpp(682) : virtual WebCore::Document::~Document()
Comment 1 Radar WebKit Bug Importer 2023-01-27 14:48:47 PST 
<rdar://problem/104762152>
Comment 2 Bri Harris 2023-01-27 14:49:12 PST 
Created attachment 464693 [details]
Crash Log
Comment 3 Ryan Haddad 2023-01-27 16:03:09 PST 
I wonder if https://commits.webkit.org/259372@main is somehow related, it landed shortly before the first crash.
Comment 4 Alexey Shvayka 2023-01-30 09:35:12 PST 
Thanks folks, that's definitely https://commits.webkit.org/259372@main, yet I don't immediately see the underlying cause: hasDisabledAttribute() in fieldset destructor is safe, addDisabledFieldsetElement() / removeDisabledFieldsetElement() call sites are unchanged...

Trying to reproduce locally now...
Comment 5 Alexey Shvayka 2023-01-30 12:16:39 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9335
Comment 6 EWS 2023-01-30 12:22:10 PST 
Committed 259580@main (f4d8caebb352): <https://commits.webkit.org/259580@main>

Reviewed commits have been landed. Closing PR #9335 and removing active labels.