Bug 251394

Summary: REGRESSION (259540@main): [ iOS ] 6 x fast/css-generated-content/ tests are constant text failures.
Product: WebKit Reporter: Bri Harris <bharris9>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bot-watchers-bugzilla, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Initial Letter Basic Diff
none
Border Padding Diff
none
Letter Clearance Diff
none
Initial Letter Descender
none
Initial Letter Raised Diff
none
Initial Letter Sunken none

Bri Harris
Reported 2023-01-30 14:04:32 PST
The following 6 tests are all constant text failures on iOS: fast/css-generated-content/initial-letter-basic.html fast/css-generated-content/initial-letter-border-padding.html fast/css-generated-content/initial-letter-clearance.html fast/css-generated-content/initial-letter-descender.html fast/css-generated-content/initial-letter-raised.html fast/css-generated-content/initial-letter-sunken.html These appear to have regressed at: https://commits.webkit.org/259540@main as all were passing prior to this commit. HISTORY: https://results.webkit.org/?suite=layout-tests&test=fast%2Fcss-generated-content%2Finitial-letter-basic.html Diff text will be attached.
Attachments
Initial Letter Basic Diff (1.12 KB, text/plain)
2023-01-30 14:05 PST, Bri Harris 		no flags
Details
Border Padding Diff (1.33 KB, text/plain)
2023-01-30 14:06 PST, Bri Harris 		no flags
Details
Letter Clearance Diff (1.47 KB, text/plain)
2023-01-30 14:06 PST, Bri Harris 		no flags
Details
Initial Letter Descender (714 bytes, text/plain)
2023-01-30 14:06 PST, Bri Harris 		no flags
Details
Initial Letter Raised Diff (1.12 KB, text/plain)
2023-01-30 14:06 PST, Bri Harris 		no flags
Details
Initial Letter Sunken (1.12 KB, text/plain)
2023-01-30 14:07 PST, Bri Harris 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Bri Harris
Comment 1 2023-01-30 14:04:40 PST
I was able to reproduce this failure as follows (run as individual tests): run-webkit-test --iOS-simulator fast/css-generated-content/initial-letter-basic.html run-webkit-test --iOS-simulator fast/css-generated-content/initial-letter-border-padding.html run-webkit-test --iOS-simulator fast/css-generated-content/initial-letter-clearance.html run-webkit-test --iOS-simulator fast/css-generated-content/initial-letter-descender.html run-webkit-test --iOS-simulator fast/css-generated-content/initial-letter-raised.html run-webkit-test --iOS-simulator fast/css-generated-content/initial-letter-sunken.html I also verified that the issue does not replicate on 259539@main.
Bri Harris
Comment 2 2023-01-30 14:05:44 PST
Created attachment 464763 [details] Initial Letter Basic Diff
Bri Harris
Comment 3 2023-01-30 14:06:04 PST
Created attachment 464764 [details] Border Padding Diff
Bri Harris
Comment 4 2023-01-30 14:06:23 PST
Created attachment 464765 [details] Letter Clearance Diff
Bri Harris
Comment 5 2023-01-30 14:06:42 PST
Created attachment 464766 [details] Initial Letter Descender
Bri Harris
Comment 6 2023-01-30 14:06:57 PST
Created attachment 464767 [details] Initial Letter Raised Diff
Bri Harris
Comment 7 2023-01-30 14:07:09 PST
Created attachment 464768 [details] Initial Letter Sunken
Radar WebKit Bug Importer
Comment 8 2023-01-30 14:07:35 PST
<rdar://problem/104836521>
Bri Harris
Comment 9 2023-01-30 14:30:26 PST
Pull request: https://github.com/WebKit/WebKit/pull/9346
Ryan Haddad
Comment 10 2023-01-30 15:40:44 PST
It seems likely that these need to be rebaselined after https://commits.webkit.org/259540@main. It looks like EWS caught it before landing..
EWS
Comment 11 2023-01-30 15:40:52 PST
Test gardening commit 259593@main (abef20a86308): <https://commits.webkit.org/259593@main> Reviewed commits have been landed. Closing PR #9346 and removing active labels.
Bri Harris
Comment 12 2023-01-31 10:50:37 PST
Pull request: https://github.com/WebKit/WebKit/pull/9391
EWS
Comment 13 2023-01-31 11:30:22 PST
Test gardening commit 259640@main (28c0165eebae): <https://commits.webkit.org/259640@main> Reviewed commits have been landed. Closing PR #9391 and removing active labels.
EWS
Comment 14 2023-02-14 13:55:20 PST
Test gardening commit 259548.166@safari-7615-branch (6fc0a52315fa): <https://commits.webkit.org/259548.166@safari-7615-branch> Reviewed commits have been landed. Closing PR #388 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.