Bug 251439

Summary:	[ews-build.webkit.org] Filter out non-reviewer validators
Product:	WebKit	Reporter:	Jonathan Bedard <jbedard>
Component:	Tools / Tests	Assignee:	Jonathan Bedard <jbedard>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Jonathan Bedard

Reported 2023-01-31 08:52:50 PST

EWS will fail a build if a non-reviewer is the only reviewer. This isn't quite the right approach if the non-reviewer is also a validator, since validators use the "review" flag to validate changes. We should filter out non-reviewer validators from our list of reviewers.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-01-31 08:53:04 PST

<rdar://problem/104869860>

Jonathan Bedard

Comment 2 2023-01-31 08:55:10 PST

Pull request: https://github.com/WebKit/WebKit/pull/9384

EWS

Comment 3 2023-01-31 09:08:15 PST

Committed 259632@main (13c76085c600): <https://commits.webkit.org/259632@main> Reviewed commits have been landed. Closing PR #9384 and removing active labels.

Jonathan Bedard

Comment 4 2023-01-31 09:53:28 PST

Re-opening for pull request https://github.com/WebKit/WebKit/pull/9387

EWS

Comment 5 2023-01-31 10:09:35 PST

Committed 259633@main (af5a52595279): <https://commits.webkit.org/259633@main> Reviewed commits have been landed. Closing PR #9387 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.