Bug 251537

Summary: WinCairo can't compile: WebGPUPresentationContextDescriptor.h(33): error C3646: 'compositorIntegration': unknown override specifier
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: WebGPUAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[fast-cq] Patch none

Fujii Hironori
Reported 2023-02-01 11:50:35 PST
WinCairo can't compile: WebGPUPresentationContextDescriptor.h(33): error C3646: 'compositorIntegration': unknown override specifier > Source\WebKit\Shared\WebGPU\WebGPUPresentationContextDescriptor.h(33): error C3646: 'compositorIntegration': unknown override specifier > Source\WebKit\Shared\WebGPU\WebGPUPresentationContextDescriptor.h(33): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int > Source\WebKit\Shared/WebGPU/WebGPUPresentationContextDescriptor.cpp(43): error C2440: 'return': cannot convert from 'initializer list' to 'std::optional<WebKit::WebGPU::PresentationContextDescriptor>' > Source\WebKit\Shared/WebGPU/WebGPUPresentationContextDescriptor.cpp(43): note: No constructor could take the source type, or constructor overload resolution was ambiguous > Source\WebKit\Shared/WebGPU/WebGPUPresentationContextDescriptor.cpp(48): error C2039: 'compositorIntegration': is not a member of 'WebKit::WebGPU::PresentationContextDescriptor' > Source\WebKit\Shared\WebGPU\WebGPUConvertToBackingContext.h(170): note: see declaration of 'WebKit::WebGPU::PresentationContextDescriptor' > Source\WebKit\Shared/WebGPU/WebGPUPresentationContextDescriptor.cpp(49): error C3536: 'compositorIntegration': cannot be used before it is initialized > Source\WebKit\Shared/WebGPU/WebGPUPresentationContextDescriptor.cpp(52): error C2100: illegal indirection > Source\WebKit\Shared/WebGPU/WebGPUPresentationContextDescriptor.cpp(52): error C2440: 'return': cannot convert from 'initializer list' to 'std::optional<PAL::WebGPU::PresentationContextDescriptor>' > Source\WebKit\Shared/WebGPU/WebGPUPresentationContextDescriptor.cpp(52): note: No constructor could take the source type, or constructor overload resolution was ambiguous
Attachments
[fast-cq] Patch (1.02 KB, patch)
2023-02-01 12:26 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2023-02-01 11:54:12 PST
Since 259669@main (bug#251479)
Fujii Hironori
Comment 2 2023-02-01 12:26:02 PST
Created attachment 464802 [details] [fast-cq] Patch
EWS
Comment 3 2023-02-01 12:36:25 PST
Committed 259709@main (a810c291903c): <https://commits.webkit.org/259709@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 464802 [details].
Radar WebKit Bug Importer
Comment 4 2023-02-01 12:37:21 PST
<rdar://problem/104927575>
Note You need to log in before you can comment on or make changes to this bug.