Bug 251567

Summary:	Move implicit mapping out of CSSPrimitiveValue
Product:	WebKit	Reporter:	Darin Adler <darin>
Component:	CSS	Assignee:	Darin Adler <darin>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	commit-queue, simon.fraser, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	All
OS:	All
Bug Depends on:	251743
Bug Blocks:

Darin Adler

Reported 2023-02-01 21:15:08 PST

The feature of CSSPrimitiveValue, where the value can be converted implicitly to various types, can happen by accident. Instead, move this into a separate class. †his frees us up to make some changes to CSSPrimitiveValue itself more easily.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-02-01 21:44:20 PST

<rdar://problem/104946191>

Darin Adler

Comment 2 2023-02-01 21:53:50 PST

Pull request: https://github.com/WebKit/WebKit/pull/9502

EWS

Comment 3 2023-02-04 08:23:07 PST

Committed 259856@main (de6b51e4e4c6): <https://commits.webkit.org/259856@main> Reviewed commits have been landed. Closing PR #9502 and removing active labels.

Simon Fraser (smfr)

Comment 4 2023-02-04 15:42:53 PST

Some tests are crashing after this: https://results.webkit.org/?suite=layout-tests&test=editing%2Finput%2Fpaste-linebreak-into-initially-hidden-textarea.html

WebKit Commit Bot

Comment 5 2023-02-04 15:46:30 PST

Re-opened since this is blocked by bug 251743

Darin Adler

Comment 6 2023-02-04 17:59:21 PST

I’ll fix the crash and re-land.

Darin Adler

Comment 7 2023-02-04 21:55:11 PST

Pull request: https://github.com/WebKit/WebKit/pull/9656

Darin Adler

Comment 8 2023-02-04 21:58:06 PST

New pull request has the crash fixed.

EWS

Comment 9 2023-02-05 09:41:31 PST

Committed 259871@main (3f84cb0e5e03): <https://commits.webkit.org/259871@main> Reviewed commits have been landed. Closing PR #9656 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.