Bug 251568

Summary:	Add CSSCounterValue, CSSQuadValue, and CSSRectValue, and use CSSValuePair
Product:	WebKit	Reporter:	Darin Adler <darin>
Component:	CSS	Assignee:	Darin Adler <darin>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	All
OS:	All

Darin Adler

Reported 2023-02-01 21:56:56 PST

In the future we will want to break CSSPrimitiveValue into specific classes for different types. One step in this direction is to do more to hide the underlying objects holding the values, which will likely eventually be held in the CSSValue itself. A good first step is to construct objects directly rather than first constructing a sub-object and passing that to the create function.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2023-02-01 21:57:51 PST

<rdar://problem/104946560>

Darin Adler

Comment 2 2023-02-06 06:49:03 PST

Pull request: https://github.com/WebKit/WebKit/pull/9686

EWS

Comment 3 2023-02-12 20:37:39 PST

Committed 260175@main (f5fc580b14bd): <https://commits.webkit.org/260175@main> Reviewed commits have been landed. Closing PR #9686 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.