Bug 251628
| Summary: | REGRESSION(256396@main): [STABLE][GStreamer] Accidentally requires GStreamer 1.18.0 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | WebKitGTK | Assignee: | Michael Catanzaro <mcatanzaro> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | aperez, bugs-noreply, mcatanzaro |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Michael Catanzaro
WebKitGTK 2.38.4 does not build with GStreamer 1.16. It requires 1.18 due to a missing GST_CHECK_VERSION check. This is an accident: 256396@main adds the check in one place, but not another.
../Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp: In function 'void WebCore::fillVideoInfoColorimetryFromColorSpace(GstVideoInfo*, const WebCore::PlatformVideoColorSpace&)':
../Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:860:57: error: 'GST_VIDEO_TRANSFER_BT601' was not declared in this scope
GST_VIDEO_INFO_COLORIMETRY(info).transfer = GST_VIDEO_TRANSFER_BT601;
^~~~~~~~~~~~~~~~~~~~~~~~
../Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:860:57: note: suggested alternative: 'GST_VIDEO_TRANSFER_BT709'
GST_VIDEO_INFO_COLORIMETRY(info).transfer = GST_VIDEO_TRANSFER_BT601;
^~~~~~~~~~~~~~~~~~~~~~~~
GST_VIDEO_TRANSFER_BT709
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Michael Catanzaro
This is a stable branch problem. We're missing 256481@main. I'll cherry-pick it.
Adrian Perez
(In reply to Michael Catanzaro from comment #1)
> This is a stable branch problem. We're missing 256481@main. I'll cherry-pick
> it.
Thanks 🙏️