Bug 251637

Summary:	Remove getNodesInCommand debug method from Editing commands
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	HTML Editing	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED WONTFIX
Severity:	Normal	CC:	bfulgham, rniwa, wenson_hsieh
Priority:	P2
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Ahmad Saleem 2023-02-02 15:05:04 PST

Hi Team,

While going through Blink's code, I came across this commit doing potential clean-up in HTML Editing code.

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/d773f6263c26f57d4148ff8ba136021f475085d8

I just wanted to raise this bug to check if we have any internal usage of this debug method or not.

Just raising for input and if we can do this clean-up or not.

Thanks!

Comment 1 Ryosuke Niwa 2023-02-02 15:18:26 PST

We could remove it but this function is useful to figure out how many DOM nodes are getting held onto by undo/redo stack.

Comment 2 Ahmad Saleem 2023-02-02 15:38:09 PST

(In reply to Ryosuke Niwa from comment #1)
> We could remove it but this function is useful to figure out how many DOM
> nodes are getting held onto by undo/redo stack.

If it is useless and we don't have alternative, I think we can close this bug but if it is something still worthwhile idea for future because we might have some in pipeline. We can keep this open, what do you suggest?

Comment 3 Ahmad Saleem 2023-02-02 15:38:24 PST

(In reply to Ahmad Saleem from comment #2)
> (In reply to Ryosuke Niwa from comment #1)
> > We could remove it but this function is useful to figure out how many DOM
> > nodes are getting held onto by undo/redo stack.
> 
> If it is useless and we don't have alternative, I think we can close this
> bug but if it is something still worthwhile idea for future because we might
> have some in pipeline. We can keep this open, what do you suggest?

*Useful - I mean.

Comment 4 Brent Fulgham 2023-02-09 14:33:57 PST

Since we use this as a debugging tool, let's close this bug.