Bug 251674

Summary:	[web-animations] clean up the keyframe recomputation code on style change
Product:	WebKit	Reporter:	Antoine Quint <graouts>
Component:	Animations	Assignee:	Antoine Quint <graouts>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	dino, graouts, koivisto, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Antoine Quint

Reported 2023-02-03 02:22:45 PST

We landed a fair few changes recently to recompute keyframes when style changes while animations are active. The ever-increasing list of parameters added to StyleResolver::keyframeStylesForAnimation() as well as the ever-growing list of change checks made in KeyframeEffectStack::applyKeyframeEffects() should be encapsulated better.

Attachments
Add attachment proposed patch, testcase, etc.

Antoine Quint

Comment 1 2023-02-03 02:37:36 PST

Pull request: https://github.com/WebKit/WebKit/pull/9591

EWS

Comment 2 2023-02-03 13:42:58 PST

Committed 259838@main (7a34ce6d9914): <https://commits.webkit.org/259838@main> Reviewed commits have been landed. Closing PR #9591 and removing active labels.

Radar WebKit Bug Importer

Comment 3 2023-02-03 13:43:22 PST

<rdar://problem/105019146>

Note You need to log in before you can comment on or make changes to this bug.