Bug 251770

Summary: [Win] REGRESSION(259818@main) error LNK2019: unresolved external symbol currentStackPointer
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: Web Template FrameworkAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: mark.lam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[fast-cq] Patch none

Description Fujii Hironori 2023-02-05 18:11:02 PST 
[Win] REGRESSION(259818@main) error LNK2019: unresolved external symbol currentStackPointer

AppleWin and WinCairo debug builds are failing after 259818@main (bug#251667).

https://build.webkit.org/#/builders/56/builds/17337

    Creating library C:/cygwin/home/buildbot/worker/Apple-Win-10-Debug-Build/build/WebKitBuild/Debug/lib64/WTF.lib and object C:/cygwin/home/buildbot/worker/Apple-Win-10-Debug-Build/build/WebKitBuild/Debug/lib64/WTF.exp
Threading.obj : error LNK2019: unresolved external symbol currentStackPointer referenced in function "private: void __cdecl WTF::StackBounds::checkConsistency(void)const " (?checkConsistency@StackBounds@WTF@@AEBAXXZ) [C:\cygwin\home\buildbot\worker\Apple-Win-10-Debug-Build\build\WebKitBuild\Debug\Source\WTF\wtf\WTF.vcxproj]
C:\cygwin\home\buildbot\worker\Apple-Win-10-Debug-Build\build\WebKitBuild\Debug\bin64\WTF.dll : fatal error LNK1120: 1 unresolved externals [C:\cygwin\home\buildbot\worker\Apple-Win-10-Debug-Build\build\WebKitBuild\Debug\Source\WTF\wtf\WTF.vcxproj]
  LowLevelInterpreterLib.vcxproj -> C:\cygwin\home\buildbot\worker\Apple-Win-10-Debug-Build\build\WebKitBuild\Debug\Source\JavaScriptCore\LowLevelInterpreterLib.dir\Debug\LowLevelInterpreterLib.lib
Comment 1 Fujii Hironori 2023-02-05 18:36:04 PST 
WTF::StackBounds::checkConsistency calls currentStackPointer only in debug builds.
https://github.com/WebKit/WebKit/blob/aea4f3f29a7c8f7dbf76e52647c30b6cfc4cc464/Source/WTF/wtf/StackBounds.h#L146
Comment 2 Fujii Hironori 2023-02-05 19:44:01 PST 
Created attachment 464858 [details]
[fast-cq] Patch
Comment 3 Mark Lam 2023-02-05 19:47:14 PST 
Comment on attachment 464858 [details]
[fast-cq] Patch

Let's post a PR on Github instead in accordance with the current workflow.
Comment 4 Fujii Hironori 2023-02-05 19:47:55 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9668
Comment 5 EWS 2023-02-05 20:07:47 PST 
Committed 259877@main (9be772528ff2): <https://commits.webkit.org/259877@main>

Reviewed commits have been landed. Closing PR #9668 and removing active labels.
Comment 6 Radar WebKit Bug Importer 2023-02-05 20:08:17 PST 
<rdar://problem/105066646>