Bug 251826
| Summary: | [webkitscmpy] Speed up files_changed | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> |
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Jonathan Bedard
The `find` function will require a request or command to convert an argument to a commit object. While that is reasonable in most circumstances, many tools will pass a hash to the files_changed function, which does not need to be converted to a Commit object to be used. Bypass the `find` call if the caller of `files_changed` passed an argument which is obviously a hash.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/105106632>
Jonathan Bedard
Pull request: https://github.com/WebKit/WebKit/pull/9726
EWS
Committed 259959@main (06835af6148a): <https://commits.webkit.org/259959@main>
Reviewed commits have been landed. Closing PR #9726 and removing active labels.
EWS
Committed 259548.64@safari-7615-branch (073b621aaa39): <https://commits.webkit.org/259548.64@safari-7615-branch>
Reviewed commits have been landed. Closing PR #364 and removing active labels.