Bug 251868
| Summary: | [MSE][GStreamer] Don't extend PTS of non-key frame | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Enrique Ocaña <eocanha> |
| Component: | Media | Assignee: | Enrique Ocaña <eocanha> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Enrique Ocaña
The edit list support patch from https://bugs.webkit.org/show_bug.cgi?id=231019 was reverted in https://bugs.webkit.org/show_bug.cgi?id=244428. While that patch isn't landed again, we're growing the first buffer of an append near the begining of the stream to make it start from 0. This workaround uses a tolerance of 0.1s, and can cause problems on frames short enough to fit more than one time in the tolerance margin (eg: 3 frames at 30fps would fit, as well as 6 frames at 60fps).
The process of growing the seconde frame that still fit in the tolerance is triggering the deletion of the first frame, which is usually a sync one. This sweeps other frames into the deletion and causes problems.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Enrique Ocaña
Pull request: https://github.com/WebKit/WebKit/pull/9769
EWS
Committed 260004@main (fa12275b80a8): <https://commits.webkit.org/260004@main>
Reviewed commits have been landed. Closing PR #9769 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/105173277>