Bug 251883

Summary: WTF::ThreadSafeWeakPtrControlBlock::strongDeref() should use constexpr
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Web Template FrameworkAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: CLOSED WONTFIX    
Severity: Normal CC: webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description David Kilzer (:ddkilzer) 2023-02-07 13:31:23 PST
WTF::ThreadSafeWeakPtrControlBlock::strongDeref() should use constexpr.

While working on another patch, I realized that WTF::ThreadSafeWeakPtrControlBlock::strongDeref() could use constexpr instead of a switch statement.

The switch statement is kept in Debug builds in case an enum value is added to DestructionThread.
Comment 1 Radar WebKit Bug Importer 2023-02-07 13:35:27 PST
<rdar://problem/105143972>
Comment 2 David Kilzer (:ddkilzer) 2023-02-07 13:37:28 PST
Pull request: https://github.com/WebKit/WebKit/pull/9779
Comment 3 David Kilzer (:ddkilzer) 2023-02-08 08:18:49 PST
Alex notes that the switch statement is already optimized out, so the constexpr isn't needed.