Bug 251918
| Summary: | Minor cleanup in PageSerializer::serializeFrame | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, ntim, rniwa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink's commit, I came across another potential merge:
Blink Commit - https://chromium.googlesource.com/chromium/blink/+/740273d8a82eb6fb83447173cf3a5f682b498bbb
WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/page/PageSerializer.cpp#193
____
Vector<Node*> serializedNodes;
SerializerMarkupAccumulator accumulator(*this, *document, &serializedNodes);
and
for (auto& node : serializedNodes) {
____
It compiles and work in local testing.
Appreciate if someone can confirm, it is right approach, so I can do PR.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
We could merge that although there doesn't seem to be much upside to it either.
Ahmad Saleem
(In reply to Ryosuke Niwa from comment #1)
> We could merge that although there doesn't seem to be much upside to it
> either.
removing unused string only I can think of. :-)
EWS
Committed 260051@main (d8939a222b9d): <https://commits.webkit.org/260051@main>
Reviewed commits have been landed. Closing PR #9821 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/105210497>