Bug 251919

Summary: Page Serializer: Specify encoding for serialized CSS files
Product: WebKit Reporter: Ahmad Saleem <ahmad.saleem792>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: ap, bfulgham, ntim, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   

Description Ahmad Saleem 2023-02-08 08:20:05 PST
Hi Team,

Wile going through Blink's commit, I came across another potential one but I am not sure, whether it will have an impact since we don't have MHTML but we seems have to have FIXME:

Blink Commit - https://chromium.googlesource.com/chromium/src.git/+/f7030ffe17ea03cf8a2e9189d7d764dfd07da26a

WebKit Source FIXME - https://searchfox.org/wubkat/source/Source/WebCore/page/PageSerializer.cpp#267

We don't have appendLiteral, so following needs to be added after Line 242:

cssText.append("@charset \"");
cssText.append(styleSheet->contents().charset().convertToASCIILowercase());
cssText.append("\";\n\n");

___

Don't know equivalent of lower() from blink commit but I think it would be 'convertToASCIILowercase()'.

Just wanted to raise a get input whether to merge it or get rid of "FIXME". Don't have testcase as well. :-(

Thanks!
Comment 1 Radar WebKit Bug Importer 2023-02-15 08:21:17 PST
<rdar://problem/105497144>