| Summary: | Avoid the unnecessary setting of min-width 0 on RenderButton & RenderMenuList | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Layout and Rendering | Assignee: | Ahmad Saleem <ahmad.saleem792> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
|
Description
Ahmad Saleem
2023-02-10 04:15:56 PST
guess now that bug 111790 is fixed, we can indeed remove this redundant call. (In reply to zalan from comment #1) > guess now that bug 111790 is fixed, we can indeed remove this redundant call. Will do PR in morning. 👍 It regresses test cases and then not match with other browser. I noticed that Blink / Chromium has various min-width hacks on their LayoutTheme for Mac-specific controls etc. They might have removed it from Blink side but kept it for Chromium theme etc. I think we needed it and Tim pointed out that it is also required by spec: ''' By default, flex items won’t shrink below their minimum content size (the length of the longest word or fixed-size element). To change this, set the min-width or min-height property. (See § 4.5 Automatic Minimum Size of Flex Items.) In the flexbox spec: https://drafts.csswg.org/css-flexbox-1/#flex-common ''' Hence, I closed my PR and closing this since we would need it. |