Bug 252049

Summary:	REGRESSION (GitHub): automatically export WPT changes when running `git webkit pr`
Product:	WebKit	Reporter:	Antoine Quint <graouts>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	NEW ---
Severity:	Normal	CC:	ntim, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Antoine Quint 2023-02-10 04:54:23 PST

Currently, exporting WPT changes requires an engineer to run `export-w3c-test-changes` as a separate step to running `git webkit pr` to upload the patch. We have a good opportunity to reduce developer friction here and promote the authoring of WPT tests within the WebKit project if WPT changes were automatically exported during the process of uploading a pull request to GitHub.

Comment 1 Antoine Quint 2023-02-10 04:57:43 PST

I'm merely a user of `export-w3c-test-changes`, but there are several manual steps required in the way I use it.

First, I have to create a token to let GitHub automate certain things. Maybe the same token can be used for WPT-related tasks and WebKit GitHub tasks, but I have two separate ones I believe.

Second, I use a local WPT checkout and have an alias such as this one to have a single command I run after running `git webkit pr`:

    alias wptexport='export-w3c-test-changes -g @ -n graouts -r graouts -d ~/Code/web-platform-tests -c -t $(cat ~/Documents/Dotfiles/wpt-export-token)'

Maybe `git webkit setup` could offer to create a local repository, although that might not offer much advantage. Same for the token creation, if required.

Comment 2 Radar WebKit Bug Importer 2023-02-10 04:58:03 PST

<rdar://problem/105269959>

Comment 3 Tim Nguyen (:ntim) 2023-02-10 23:13:11 PST

This is a regression of the Github migration fwiw, the webkit-patch script used to detect WPT changes and ask whether you wanted to run the export command.