Bug 252134

Summary:	[browserperfdash-benchmark] Support configuring a specific set of plans and default config values on the config file
Product:	WebKit	Reporter:	Carlos Alberto Lopez Perez <clopez>
Component:	Tools / Tests	Assignee:	Carlos Alberto Lopez Perez <clopez>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bugs-noreply, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=252355
Bug Depends on:
Bug Blocks:	249031

Description Carlos Alberto Lopez Perez 2023-02-12 11:32:40 PST

The GTK perf bot, on the benchmark-test step, is currently running all available plans with the switch --allplans, but some plans are repeated (just using different versions).

$ Tools/Scripts/run-benchmark --list-plans
Available benchmark plans: 
	dromaeo-cssquery
	octane
	jetstream
	content-animation
	ares6
	motionmark1.1
	jetstream2.0
	motionmark
	speedometer1.0
	speedometer2
	motionmark1.2.1
	speedometer
	kraken
	sunspider
	stylebench
	speedometer2.1
	jetstream2.1
	dromaeo-jslib
	jetstream2
	motionmark1.0
	jsbench
	speedometer2.0
	dromaeo-dom

And this is causing issues there, because the bot is doing repeated work that is not really useful.
So it would be desirable to be able to configure it to run a specific subset of all the available plans.

Allowing this will be also very good for the upcoming WPE RPi testers were some plans can cause issues on the system due to RAM memory constrains or other issues.

Comment 1 Carlos Alberto Lopez Perez 2023-02-12 13:28:13 PST

Also allowing to configure default values for the different settings (like the browser to run) in the config file is desirable.

Comment 2 Carlos Alberto Lopez Perez 2023-02-12 14:12:48 PST

Pull request: https://github.com/WebKit/WebKit/pull/10003

Comment 3 Radar WebKit Bug Importer 2023-02-19 11:33:17 PST

<rdar://problem/105651627>

Comment 4 EWS 2023-03-01 04:00:08 PST

Committed 260997@main (76fca0c6015a): <https://commits.webkit.org/260997@main>

Reviewed commits have been landed. Closing PR #10003 and removing active labels.