Bug 252169
| Summary: | _web_capitalizeRFC822HeaderFieldName leaks memory | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Seija K. <gfunni234> |
| Component: | WebKit API | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | Normal | CC: | darin |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Seija K.
We do not free the backing buffer because we pass nullptr as the last argument to the noCopy functions and never explicitly deallocate.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Seija K.
Pull request: https://github.com/WebKit/WebKit/pull/10039
Darin Adler
How did you notice this bug? Code inspection or some type of testing. Could you supply more context to your work?
The WebKit project requires regression tests when we fix bugs. Maybe we can forgo that in this case but I would like to know more about how it was discovered to make that decision.
Darin Adler
If we made a test, we’d see there’s no bug here. We do free the backing buffer. Passing nullptr as the last argument tells it to use the default allocator to deallocate.