Bug 252213
| Summary: | [WGSL] Fix line number reporting in errors | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Dan Glastonbury <djg> |
| Component: | WebGPU | Assignee: | Dan Glastonbury <djg> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Dan Glastonbury
Text editors use one-based line numbering, not zero. When setting source
code to be tokenized, set the current position to offset of 0 on line 1. This
allows a position with m_line set to 0 to represent and empty or invalid
position.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/105423092>
Dan Glastonbury
Pull request: https://github.com/WebKit/WebKit/pull/10064
EWS
Committed 260237@main (5152a874639a): <https://commits.webkit.org/260237@main>
Reviewed commits have been landed. Closing PR #10064 and removing active labels.