Bug 252261

Summary: [Win] SHOULD NEVER BE REACHED: PrivateClickMeasurementDatabase.cpp(371) : WebKit::PCM::Database::allAttributedPrivateClickMeasurement
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: WebKit2Assignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: don.olmstead, kkinnunen, ross.kirsling, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Fujii Hironori 2023-02-14 13:22:11 PST 
[Win] SHOULD NEVER BE REACHED: PrivateClickMeasurementDatabase.cpp(371) : WebKit::PCM::Database::allAttributedPrivateClickMeasurementw

1. Start WinCairo MiniBrowser of Debug build
2. Wait for a few seconds
3. An assertion fails

SHOULD NEVER BE REACHED
C:\home\webkit\gb\Source\WebKit\NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementDatabase.cpp(371) : WebKit::PCM::Database::allAttributedPrivateClickMeasurement
1   00007FFEA260249B WTFCrash
2   00007FFE98322C0E WTFCrashWithInfo
3   00007FFE9916C639 WebKit::PCM::Database::allAttributedPrivateClickMeasurement
4   00007FFE991DA1E1 `WebKit::PCM::Store::allAttributedPrivateClickMeasurement'::`2'::<lambda_1>::operator()
5   00007FFE991E560B WTF::Detail::CallableWrapper<`WebKit::PCM::Store::allAttributedPrivateClickMeasurement'::`2'::<lambda_1>,void>::call
6   00007FFEA261A483 WTF::Function<void __cdecl(void)>::operator()
7   00007FFEA26BAAC8 `WTF::SuspendableWorkQueue::dispatch'::`2'::<lambda_1>::operator()
8   00007FFEA26BB10B WTF::Detail::CallableWrapper<`WTF::SuspendableWorkQueue::dispatch'::`2'::<lambda_1>,void>::call
9   00007FFEA261A483 WTF::Function<void __cdecl(void)>::operator()
10  00007FFEA278E0EB `WTF::WorkQueueBase::dispatch'::`2'::<lambda_1>::operator()
11  00007FFEA278E85B WTF::Detail::CallableWrapper<`WTF::WorkQueueBase::dispatch'::`2'::<lambda_1>,void>::call
12  00007FFEA261A483 WTF::Function<void __cdecl(void)>::operator()
13  00007FFEA26B0AD8 WTF::RunLoop::performWork
14  00007FFEA279B631 WTF::RunLoop::wndProc
15  00007FFEA279B594 WTF::RunLoop::RunLoopWndProc
16  00007FFF1CDAE7E8 CallWindowProcW
17  00007FFF1CDAE229 DispatchMessageW
18  00007FFEA279AB16 WTF::RunLoop::run
19  00007FFEA26B0BAD `WTF::RunLoop::create'::`2'::<lambda_1>::operator()
20  00007FFEA26B0E2B WTF::Detail::CallableWrapper<`WTF::RunLoop::create'::`2'::<lambda_1>,void>::call
21  00007FFEA261A483 WTF::Function<void __cdecl(void)>::operator()
22  00007FFEA26C00A8 WTF::Thread::entryPoint
23  00007FFEA279D2B4 WTF::wtfThreadEntryPoint
24  00007FFF1B1E1BB2 configthreadlocale
25  00007FFF1C8C7614 BaseThreadInitThunk
26  00007FFF1D8E26A1 RtlUserThreadStart
Exception thrown at 0x00007FFEA26024A0 (WTF.dll) in WebKitNetworkPro
Comment 1 Fujii Hironori 2023-02-14 13:53:54 PST 
See also: Bug 231175 – [GTK][WPE] Disable privateClickMeasurement when creating the network process
Comment 2 Fujii Hironori 2023-02-14 13:58:57 PST 
Created attachment 464986 [details]
Patch
Comment 3 Don Olmstead 2023-02-14 14:04:04 PST 
Comment on attachment 464986 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464986&action=review

> Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:219
> -#if PLATFORM(GTK) || PLATFORM(WPE)
> +#if PLATFORM(GTK) || PLATFORM(WPE) || PLATFORM(WIN)

Should this be `!PLATFORM(COCOA)`?
Comment 4 Fujii Hironori 2023-02-14 14:14:45 PST 
Created attachment 464987 [details]
Patch
Comment 5 EWS 2023-02-14 17:01:39 PST 
Committed 260287@main (318c1ac13d57): <https://commits.webkit.org/260287@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 464987 [details].
Comment 6 Radar WebKit Bug Importer 2023-02-14 17:02:20 PST 
<rdar://problem/105474437>