| Summary: | [IFC][Partial layout] Compute damage extent when appending text content | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | bfulgham, Hironori.Fujii, koivisto, ross.kirsling, simon.fraser, webkit-bug-importer, zalan | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
zalan
2023-02-14 18:07:13 PST
Created attachment 464992 [details]
Patch
Created attachment 465036 [details]
Patch
Committed 260407@main (df7677f05993): <https://commits.webkit.org/260407@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 465036 [details]. This does not build on Windows:
> layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp(62): error C3487: 'unsigned long': all return expressions must deduce to the same type: previously it was 'size_t'
> layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp(61): error C3487: 'unsigned long': all return expressions must deduce to the same type: previously it was 'size_t'
(In reply to Ross Kirsling from comment #5) > This does not build on Windows: > > > layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp(62): error C3487: 'unsigned long': all return expressions must deduce to the same type: previously it was 'size_t' > > layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp(61): error C3487: 'unsigned long': all return expressions must deduce to the same type: previously it was 'size_t' :( sorry about that. should have paid attention to the red bubble. Created attachment 465041 [details]
[fast-cq]Patch
Build fix.
broke the build. WinCairo EWS waiting queue is long since the build failure. I confirmed your patch fixes WinCairo build. Thank you. (In reply to Fujii Hironori from comment #9) > WinCairo EWS waiting queue is long since the build failure. I confirmed your > patch fixes WinCairo build. Thank you. Thank you for confirming it. let me [fast-cq]+ it! Created attachment 465042 [details]
[fast-cq] build fix
(In reply to Fujii Hironori from comment #11) > Created attachment 465042 [details] > [fast-cq] Patch :( thanks. Committed 260421@main (7ba52be59233): <https://commits.webkit.org/260421@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 465042 [details]. |