Bug 252279

Summary: [IFC][Partial layout] Compute damage extent when appending text content
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, fujii.hironori, koivisto, ross.kirsling, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
[fast-cq]Patch
none
[fast-cq] build fix none

alan
Reported 2023-02-14 18:07:13 PST
ssia
Attachments
Patch (9.87 KB, patch)
2023-02-14 18:38 PST, alan 		no flags
DetailsFormatted DiffDiff
Patch (9.94 KB, patch)
2023-02-16 15:15 PST, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq]Patch (1.47 KB, patch)
2023-02-16 20:29 PST, alan 		no flags
DetailsFormatted DiffDiff
[fast-cq] build fix (2.11 KB, patch)
2023-02-16 21:20 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2023-02-14 18:38:01 PST
Created attachment 464992 [details] Patch
alan
Comment 2 2023-02-16 15:15:30 PST
Created attachment 465036 [details] Patch
EWS
Comment 3 2023-02-16 17:14:57 PST
Committed 260407@main (df7677f05993): <https://commits.webkit.org/260407@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 465036 [details].
Radar WebKit Bug Importer
Comment 4 2023-02-16 17:15:20 PST
<rdar://problem/105572646>
Ross Kirsling
Comment 5 2023-02-16 19:21:24 PST
This does not build on Windows: > layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp(62): error C3487: 'unsigned long': all return expressions must deduce to the same type: previously it was 'size_t' > layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp(61): error C3487: 'unsigned long': all return expressions must deduce to the same type: previously it was 'size_t'
alan
Comment 6 2023-02-16 20:05:34 PST
(In reply to Ross Kirsling from comment #5) > This does not build on Windows: > > > layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp(62): error C3487: 'unsigned long': all return expressions must deduce to the same type: previously it was 'size_t' > > layout/formattingContexts/inline/invalidation/InlineInvalidation.cpp(61): error C3487: 'unsigned long': all return expressions must deduce to the same type: previously it was 'size_t' :( sorry about that. should have paid attention to the red bubble.
alan
Comment 7 2023-02-16 20:29:44 PST
Created attachment 465041 [details] [fast-cq]Patch Build fix.
alan
Comment 8 2023-02-16 20:30:35 PST
broke the build.
Fujii Hironori
Comment 9 2023-02-16 20:32:46 PST
WinCairo EWS waiting queue is long since the build failure. I confirmed your patch fixes WinCairo build. Thank you.
alan
Comment 10 2023-02-16 20:48:43 PST
(In reply to Fujii Hironori from comment #9) > WinCairo EWS waiting queue is long since the build failure. I confirmed your > patch fixes WinCairo build. Thank you. Thank you for confirming it. let me [fast-cq]+ it!
Fujii Hironori
Comment 11 2023-02-16 21:20:17 PST
Created attachment 465042 [details] [fast-cq] build fix
alan
Comment 12 2023-02-16 21:21:15 PST
(In reply to Fujii Hironori from comment #11) > Created attachment 465042 [details] > [fast-cq] Patch :( thanks.
EWS
Comment 13 2023-02-16 21:29:52 PST
Committed 260421@main (7ba52be59233): <https://commits.webkit.org/260421@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 465042 [details].
Note You need to log in before you can comment on or make changes to this bug.