| Summary: | [IFC][Partial layout] Do not rely on the number of lines in InlineFormattingState when computing the current line index. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
zalan
2023-02-14 19:31:15 PST
Created attachment 464994 [details]
Patch
Comment on attachment 464994 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=464994&action=review > COMMIT_MESSAGE:1 > +[IFC][Partial layout] Using the number of cached lines in InlineFormattingState as a hint for the current line index does not work well with partial layout Not sure I understand the title. InlineFormattingState only contains the line generated at the current layout. With partial layout, this number may be very different from how many lines we actually have altogether. Committed 260372@main (2e812cbdaf7d): <https://commits.webkit.org/260372@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 464994 [details]. oops, I forgot to change the title in the commit message :( |