Bug 252368

Summary: [IFC][Partial layout] LineLayout::layout should not destroy inline display content on partial layout
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description zalan 2023-02-15 18:09:58 PST
ssia
Comment 1 zalan 2023-02-15 18:12:36 PST
Created attachment 465015 [details]
Patch
Comment 2 Antti Koivisto 2023-02-16 07:16:40 PST
Comment on attachment 465015 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=465015&action=review

> Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:533
> +    // FIXME: Partial layout should not rely on inline display content, but instead InlineFormattingState
> +    // should retain all the pieces of data required -and then we can destroy damaged content here instead of after
> +    // layout in constructContent.

good plan
Comment 3 zalan 2023-02-16 16:39:53 PST
Created attachment 465039 [details]
Patch
Comment 4 EWS 2023-02-17 09:04:40 PST
Committed 260448@main (7949435ac60b): <https://commits.webkit.org/260448@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 465039 [details].
Comment 5 Radar WebKit Bug Importer 2023-02-17 09:05:20 PST
<rdar://problem/105599284>