Bug 252379

Summary:

REGRESSION (255598@main): checkbox overlaps Log In button on ally.com

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, simon.fraser, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description zalan 2023-02-15 21:47:56 PST

<rdar://104303475>

Comment 1 zalan 2023-02-15 21:57:08 PST

Created attachment 465019 [details]
Patch

Comment 2 Antti Koivisto 2023-02-16 07:00:00 PST

Comment on attachment 465019 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=465019&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp:278
> +        if (displayBox.isInlineLevelBox() && !displayBox.isRootInlineBox())

there is isNonRootInlineLevelBox()

Comment 3 zalan 2023-02-16 07:22:28 PST

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 465019 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=465019&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp:278
> > +        if (displayBox.isInlineLevelBox() && !displayBox.isRootInlineBox())
> 
> there is isNonRootInlineLevelBox()
!!!

Comment 4 zalan 2023-02-16 07:50:54 PST

Created attachment 465026 [details]
Patch

Comment 5 EWS 2023-02-16 10:21:21 PST

Committed 260380@main (3cf4b3198445): <https://commits.webkit.org/260380@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 465026 [details].