Bug 252442
| Summary: | Add String / StringView find() overloads that take in a LChar / char instead of a UChar | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> |
| Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Chris Dumez
Add String / StringView find() overloads that take in a LChar / char instead of a UChar. It is pretty common to see code in WebKit doing `string.find(':')`. When the input string is 8-bit, converting ':' to a UChar can be inefficient as we have optimized versions of StringImpl::find() / WTF::find() that take in a LChar/char.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Chris Dumez
Pull request: https://github.com/WebKit/WebKit/pull/10239
EWS
Committed 260415@main (2984e2efc933): <https://commits.webkit.org/260415@main>
Reviewed commits have been landed. Closing PR #10239 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/105576849>