Bug 252480

Summary: [GStreamer][MSE] Reinstall matroskademuxForceSegmentStartToEqualZero probe on relinking
Product: WebKit Reporter: Enrique Ocaña <eocanha>
Component: MediaAssignee: Enrique Ocaña <eocanha>
Status: RESOLVED FIXED    
Severity: Normal CC: jacekskiba.88, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Enrique Ocaña 2023-02-17 05:56:05 PST 
When a matroskademux src pad is relinked (because the old one was removed), the
probe that corrects the segment start is lost with the disappearing pad and
never reinstalled on the replacing one. This can cause issues, for instance,
while doing trick playback in reverse on Broadcom devices, which don't need
parsers.

During trickplay, pads between demux and appsink elements are relinked.
GstBuffers related to trick playback are rejected/clipped by appsink (more
precisely, by its base class: GstBaseSink), because GstSegment start position
value don't match to those GstBuffers.

See: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1033
Comment 1 Enrique Ocaña 2023-02-17 06:23:59 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10275
Comment 2 EWS 2023-02-24 04:41:09 PST 
Committed 260794@main (61138013faef): <https://commits.webkit.org/260794@main>

Reviewed commits have been landed. Closing PR #10275 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-02-24 04:42:20 PST 
<rdar://problem/105879436>