Bug 252507
| Summary: | [Multicolumn] Margins incorrectly accounted for before forced breaks | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ahmad Saleem <ahmad.saleem792> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Safari Technology Preview | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ahmad Saleem
Hi Team,
While going through Blink's commit, I came across another potential merge fixing bug in multicolumn.
Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=188456
WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderBlockFlow.cpp#1710
Failing Test Case (in Safari 16.3 & STP163) - https://jsfiddle.net/7tnzdkc4/show & https://jsfiddle.net/Lmr9p1af/show
^ Tested locally and WebKit ToT passes them after this merge.
Raising this bug so I can do PR.
Thanks!
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
EWS
Committed 260510@main (e75a5cd7e299): <https://commits.webkit.org/260510@main>
Reviewed commits have been landed. Closing PR #10307 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/105631038>