Bug 252516

Summary: Import wpt /css/css-tables WPT Tests from upstream
Product: WebKit Reporter: Ahmad Saleem <ahmad.saleem792>
Component: Tools / TestsAssignee: Karl Dubost <karlcow>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, jenner, ntim, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=256040
https://bugs.webkit.org/show_bug.cgi?id=257336

Description Ahmad Saleem 2023-02-17 18:06:46 PST 
Hi Team,

I think it would be good idea to bring these tests so we can track any progression and regression in these tests.

I am not sure on how to do it but if someone can point to any guidance, I am happy to do it but meanwhile I would need someone else help.

Just raising this bug for tracking purposes.

Thanks!
Comment 1 Tim Nguyen (:ntim) 2023-02-18 00:03:48 PST 
Here are the steps to do a WPT import:

1. Run `import-w3c-tests -t web-platform-tests/css/css-tables`
2. `run-webkit-tests imported/w3c/web-platform-tests/css/css-tables` to generate test expectations as needed.
3. Mark expectations as needed in `LayoutTests/TestExpectations`
Comment 2 Radar WebKit Bug Importer 2023-02-24 18:07:18 PST 
<rdar://problem/105909906>
Comment 3 Karl Dubost 2023-05-16 07:37:21 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/13920
Comment 4 Karl Dubost 2023-05-16 08:00:50 PDT 
This should help with Bug 256040
Comment 5 EWS 2023-05-18 20:35:20 PDT 
Committed 264228@main (746ac181da01): <https://commits.webkit.org/264228@main>

Reviewed commits have been landed. Closing PR #13920 and removing active labels.
Comment 6 Robert Jenner 2023-05-25 14:18:18 PDT 
I am reopening to make an adjustment to the expectations that have been set for the following four tests introduced in this bug:

imported/w3c/web-platform-tests/css/css-tables/calc-percent-plus-0px-auto.html
imported/w3c/web-platform-tests/css/css-tables/calc-percent-plus-0px-fixed.html
imported/w3c/web-platform-tests/css/css-tables/col-definite-max-size-001.html
imported/w3c/web-platform-tests/css/css-tables/col-definite-size-001.html


Current expectation is [ Crash ] but it looks like it should be [ Crash ImageOnlyFailure ]
Comment 8 EWS 2023-05-25 14:27:19 PDT 
Test gardening commit 264540@main (ff075b09d12b): <https://commits.webkit.org/264540@main>

Reviewed commits have been landed. Closing PR #14367 and removing active labels.