| Summary: | [Wasm-GC] Bytecode dumper crashes when printing code with nested arrays | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Chevalier <tjc> |
| Component: | WebAssembly | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 247394 | ||
Pull request: https://github.com/WebKit/WebKit/pull/10339 Committed 260637@main (506f2789666c): <https://commits.webkit.org/260637@main> Reviewed commits have been landed. Closing PR #10339 and removing active labels. |
Running the following test with the bytecode dumper enabled: ``` import * as assert from "../assert.js"; import { compile, instantiate } from "./wast-wrapper.js"; function module(bytes, valid = true) { let buffer = new ArrayBuffer(bytes.length); let view = new Uint8Array(buffer); for (let i = 0; i < bytes.length; ++i) { view[i] = bytes.charCodeAt(i); } return new WebAssembly.Module(buffer); } function testArray() { let m = instantiate(`(module (type $bvec (array i8)) (type $a (array (ref $bvec))) (func $new (export "new") (result (ref $a)) (array.new_canon $a (array.new_canon_default $bvec (i32.const 2)) (i32.const 42))))`); } testArray(); ``` command line: `jsc -m --useWebAssemblyTypedFunctionReferences\=true --useWebAssemblyGC\=true --dumpGeneratedWasmBytecodes=true test_array.js` results in a crash: ``` <?>.wasm-function[0] : () -> [Ref] wasm size: 12 bytes bytecode: 5 instructions (0 16-bit instructions, 1 32-bit instructions); 33 bytes; 0 parameter(s); 18 local(s); 20 callee register(s) [ 0] enter [ 1] **array_new dst:loc18, size:SHOULD NEVER BE REACHED /home/tjc/WebKit/Source/JavaScriptCore/bytecode/BytecodeDumper.cpp(438) : WTF::CString JSC::Wasm::BytecodeDumper::formatConstant(JSC::Wasm::Type, uint64_t) const Aborted (core dumped) ``` I have a fix for this, which I'll submit shortly.