Bug 252593

Summary: Move RenderText::canUseSimplifiedTextMeasuring logic to TextUtil
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, mmaxfield, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
[fast-cq]Patch none

Description zalan 2023-02-20 12:04:05 PST
ssia
Comment 1 zalan 2023-02-20 15:12:52 PST
Created attachment 465095 [details]
Patch
Comment 2 zalan 2023-02-20 20:35:32 PST
Created attachment 465101 [details]
Patch
Comment 3 zalan 2023-02-20 20:49:32 PST
Created attachment 465102 [details]
Patch
Comment 4 Antti Koivisto 2023-02-21 07:05:47 PST
Comment on attachment 465102 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=465102&action=review

> Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp:199
> +        auto canUseSimplifiedTextMeasuring = canUseSimpleFontCodePath ? Layout::TextUtil::canUseSimplifiedTextMeasuring(text, style, firstLineStyle.get()) : false;

canUseSimpleFontCodePath && Layout::TextUtil::canUseSimplifiedTextMeasuring(text, style, firstLineStyle.get())

is shorter.
Comment 5 zalan 2023-02-21 09:07:32 PST
Created attachment 465110 [details]
Patch
Comment 6 zalan 2023-02-22 07:05:47 PST
Created attachment 465119 [details]
[fast-cq]Patch
Comment 7 EWS 2023-02-22 07:19:16 PST
Committed 260675@main (7d5263e5eaa4): <https://commits.webkit.org/260675@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 465119 [details].
Comment 8 Radar WebKit Bug Importer 2023-02-22 07:20:23 PST
<rdar://problem/105778355>