Bug 252627

Summary:	Recognize CSSUnitType::CSS_X as a resolution calc unit category
Product:	WebKit	Reporter:	Ryan Reno <rreno>
Component:	CSS	Assignee:	Ryan Reno <rreno>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://github.com/web-platform-tests/wpt/pull/38624

Description Ryan Reno 2023-02-20 15:58:30 PST

An expression like "calc(1x * 2)" does not recognize the 1x as a resolution unit when resolving the calc unit category. It defaults to CalculationCategory::Other which causes the parser to fail parsing the expression in the calc function if it's expecting a Dimension result.

Comment 1 Radar WebKit Bug Importer 2023-02-20 15:59:08 PST

<rdar://problem/105700660>

Comment 2 Ryan Reno 2023-02-20 16:08:25 PST

Pull request: https://github.com/WebKit/WebKit/pull/10412

Comment 3 Ryan Reno 2023-02-21 12:02:37 PST

Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/38624

Comment 4 EWS 2023-02-22 09:22:02 PST

Committed 260678@main (310f6772fe38): <https://commits.webkit.org/260678@main>

Reviewed commits have been landed. Closing PR #10412 and removing active labels.