Bug 252629

Summary:	REGRESSION(260471@main): The platform graphics context colorspace should not be adopted
Product:	WebKit	Reporter:	Said Abou-Hallawa <sabouhallawa>
Component:	Layout and Rendering	Assignee:	Said Abou-Hallawa <sabouhallawa>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=252382 https://bugs.webkit.org/show_bug.cgi?id=252856

Description Said Abou-Hallawa 2023-02-20 16:03:10 PST

When storing the return raw pointer of CGIOSurfaceContextGetColorSpace() or CGBitmapContextGetColorSpace() in a RetainPtr, we should not be using adoptCF(). The RetainPtr refcount should be incremented if the colorspace is referenced in WebKit.

Comment 1 Said Abou-Hallawa 2023-02-20 16:03:51 PST

rdar://105637444

Comment 2 Said Abou-Hallawa 2023-02-20 16:47:14 PST

Pull request: https://github.com/WebKit/WebKit/pull/10413

Comment 3 EWS 2023-02-21 07:21:30 PST

Committed 260609@main (fab6d531c24f): <https://commits.webkit.org/260609@main>

Reviewed commits have been landed. Closing PR #10413 and removing active labels.